Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for mTLS Proof-of-Possession (PoP) with attestation for managed identity token acquisition, and adds a new sample app demonstrating this feature. The main changes include updating dependencies, modifying token acquisition logic, and adding a new test application with configuration and documentation.
Dependency updates and token acquisition enhancements:
Microsoft.Identity.Client.KeyAttestationas a dependency inDirectory.Build.propsandMicrosoft.Identity.Web.TokenAcquisition.csprojto enable attestation support. [1] [2] [3]TokenAcquisition.csto useMicrosoft.Identity.Client.KeyAttestationand to enable mTLS PoP and attestation when theIsTokenBindingoption is set. [1] [2]Sample app additions for demonstration:
daemon-app-msi-v2to the solution, including project file, source code, configuration, and documentation. [1] [2] [3] [4]Program.csfor the sample app, showing how to use managed identity with attestation to retrieve a Key Vault secret.appsettings.jsonfor the sample app, including configuration for managed identity, Key Vault access, and enabling mTLS PoP with attestation.readme.mdexplaining prerequisites and the flow of the sample app.Up Next: