Bugfix for AXI4_BSV_RTL.bsv #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally had 5 rules, one for each AXI4 channel (AW, W, B, AR, R).
Each rule was connecting both the ready and valid signals.
This forced the two directions to be scheduled together (too strict).
This bugfix splits each rule into two, one for ready and one for valid.
quark17
approved these changes
Mar 16, 2025
Collaborator
quark17
left a comment
quark17
left a comment
There was a problem hiding this comment.
Looks good. I vaguely recall having to separate the rules like this on another project in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes scheduling by splitting some rules