CI: Support disabling timeouts for a build-and-test workflow #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quark17
force-pushed
the
ci-update-timeout
branch
2 times, most recently
from
62b4b47 to
906d5fe
Compare
since Homebrew doesn't support macOS 13 now, so the packages are installed from source, which is slow. The build-and-test workflows now take an input specifying whether to override the timeouts, by setting them to the maximum (360).
quark17
force-pushed
the
ci-update-timeout
branch
2 times, most recently
from
b4cbd42 to
0d35808
Compare
For macOS 13, Homebrew only has to resort to source install for newer package versions, so don't update the package list for that runner. The build-and-test-macos workflow now takes an input specifying whether to update Homebrew.
quark17
force-pushed
the
ci-update-timeout
branch
from
0d35808 to
15c0a0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
timeout_overrideinput to thebuild-and-test-macosandbuild-and-test-ubuntucall-able workflows. It's used to turn off timeouts formacos-13.Homebrew no longer supports macOS 13, so installs are often from source, which can take a long time. The install of dependencies was taking a long time and exceeding the timeout. Because the GitHub VM images can sometimes be old, we added
brew updateto our jobs, to make sure that Homebrew sees the latest packages; but this can possibly cause Homebrew to install packages that don't need updating. We installccache, to help save time by caching C/C++ compiler outputs, but the install of that was requiring the install of things likerustthat would take 80 minutes to compile from source! Potentially, we could add a flag for disabling the use ofccache, but that might be complicated, as it would require a conditional in the install shell scripts and conditionals on and in various steps of the jobs.We only need
macos-13long enough to build a tar-file for the imminent release, then we can remove it. So for now, I've just added a flag for disabling timeouts.