Libraries: Remove StmtFSMUtil, update depends.mk #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StmtFSMUtil library has been unused since 2008, and was removed from the Makefile build and dependencies, but the source was not removed. In 2013, the dependencies were moved to a separate 'depend.mk' file, that can be automatically built. In doing so, StmtFSMUtil was added back to the dependencies. In 2020, when BSC was released as open source, it was overlooked that StmtFSMUtil was not needed, and so it was included. The contents of the library seem to be modules for creating the state register, in a way that BSC would notice are mutually exclusive; this is no longer needed, either because BSC's analysis has improved or because BSC has better ways of specifying scheduling relationships (such as rJoinMutuallyExclusive). The 'depends.mk' file has been updated, which removed the dependencies for StmtFSMUtil, but also updates dependencies for several libraries that have changed. In 2020, unnecessary imports were removed for a number of libraries, but the depends file was not updated at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StmtFSMUtil library has been unused since 2008 and was only accidentally included in the open source release. The contents appear to be modules for creating the state register in a way that BSC would notice are mutually exclusive. This is no longer needed, either because BSC's analysis has significantly improved or because BSC has better ways of specifying scheduling relationships (such as rJoinMutuallyExclusive); I don't believe there's any use for the library, so this PR removes it.
This also updates the 'depends.mk' file, which removes the dependencies for StmtFSMUtil, but also updates dependencies for several libraries that have changed since the last update. Unnecessary imports were removed from several libraries in a previous commit, but the depends file was not updated at the time. We might consider adding an automated check of the depends files to the CI.