Fix off-by-one column tracking for $-prefixed identifiers #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern `('$':x:cs)` consumes two characters (the '$' and the first
identifier character 'x'), so the remaining input `cs` starts at column
`c+2`, not `c+1`.
This bug caused incorrect column positions to be reported for Verilog
system tasks like $display, $finish, $time, etc. All subsequent tokens
on the same line after a $-identifier would have their column numbers
off by one.
quark17
force-pushed
the
fix-dollar-identifier-column
branch
from
28f87a3 to
173ea5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #873 so that I can push changes and get this merged quickly.