Release next: Keycloak 26.6.1, dependency updates, location condition authenticator#216
Open
BenLad17 wants to merge 31 commits into
Open
Release next: Keycloak 26.6.1, dependency updates, location condition authenticator#216BenLad17 wants to merge 31 commits into
BenLad17 wants to merge 31 commits into
Conversation
- Use Constants.CFG_DELIMITER_PATTERN instead of hardcoded "##" - Add null guard for missing authenticator config (fail-closed) - Use getOrDefault for CONFIG_VALUES to prevent NPE - Fix getRequirementChoices() to return [REQUIRED, DISABLED] - Fix setDefaultValue(false) type mismatch on MULTIVALUED_STRING_TYPE - Fix variable typo: reveseDecision -> reverseDecision - Fix help text typo: "Revert de condition" -> "Revert the condition" - Remove unused imports - Clean up trailing \n in help text strings
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Java |  |
Apr 27, 2026 4:43a.m. | Review ↗ |
| Code coverage | |
Apr 27, 2026 4:43a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 100% |
| Java | 100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
…uthenticatorFactory
…ycloakApplication.getTmpDirectory()
…tion Save userId before realm deletion and wait for deletion to complete before querying login records. Avoids NotFoundException from user.getId() when the realm is already gone.
Deleting the framework-managed realm caused OAuthClient.close() to fail in afterEach (re-created realm lacks the test OAuth client), aborting the destroy loop and cascading 409s to all subsequent tests. Fix: create a separate temp realm + user, insert a record directly via JDBC, delete the temp realm, verify cascade. Framework realm untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan