Skip to content

Switch adam-assist to upstream assist 1.2.0#31

Merged
akoumjian merged 6 commits intomainfrom
codex/assist-1-2-0-upstream
Apr 8, 2026
Merged

Switch adam-assist to upstream assist 1.2.0#31
akoumjian merged 6 commits intomainfrom
codex/assist-1-2-0-upstream

Conversation

@akoumjian
Copy link
Copy Markdown
Contributor

Summary

  • replace assist-adam-fork==1.1.9.post1 with assist==1.2.0 in pyproject.toml
  • remove obsolete temporary comment about waiting for upstream SPK support

Validation

  • pytest -q
    • result: 93 passed, 3 warnings in 373.77s (0:06:13)

Notes

  • This PR intentionally excludes local grounding files (journal.md, decisions.md) and local virtualenv artifacts.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python Benchmark

Details
Benchmark suite Current: ece8902 Previous: 2d92fb4 Ratio
tests/test_benchmarks.py::test_benchmark_propagation_vs_raw 0.31250859951398174 iter/sec (stddev: 0.01937369076429311) 0.2736623156041147 iter/sec (stddev: 0.013239537411544355) 0.88
tests/test_benchmarks.py::test_benchmark_ephemeris_generation 17.94488836229758 iter/sec (stddev: 0.000574782414767223) 12.930319748185006 iter/sec (stddev: 0.00150480892395251) 0.72
tests/test_benchmarks.py::test_benchmark_impact_detection 0.4532077228754691 iter/sec (stddev: 0.00292446966657825) 0.5192673938530772 iter/sec (stddev: 0.002842279362662687) 1.15
tests/test_impacts.py::test_calculate_impacts_benchmark_some_impacts[1] 0.4502283933451297 iter/sec (stddev: 0.016662612301998836) 0.5179347788369499 iter/sec (stddev: 0.003957762656902414) 1.15
tests/test_impacts.py::test_calculate_impacts_benchmark_some_impacts[2] 0.6408398529255908 iter/sec (stddev: 0.011113043935773196) 0.7455829497528665 iter/sec (stddev: 0.02035945643498696) 1.16
tests/test_impacts.py::test_calculate_impacts_benchmark_impacts[1] 1.9179527111144479 iter/sec (stddev: 0.0018719757360152328) 2.1974820637854897 iter/sec (stddev: 0.003333189570091175) 1.15
tests/test_impacts.py::test_calculate_impacts_benchmark_impacts[2] 2.640262312933431 iter/sec (stddev: 0.004006867828831393) 2.9941973670670925 iter/sec (stddev: 0.004578086236686925) 1.13
tests/test_impacts.py::test_calculate_impacts_benchmark_no_impacts[1] 0.019724928953419357 iter/sec (stddev: 0.06322866166754969) 0.022791391541279744 iter/sec (stddev: 0.04799276114740024) 1.16
tests/test_impacts.py::test_calculate_impacts_benchmark_no_impacts[2] 0.040053552392288375 iter/sec (stddev: 0.12841780308118628) 0.0467388709667549 iter/sec (stddev: 0.11497080193893268) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

@akoumjian akoumjian merged commit db188e4 into main Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant