Fix: TypeError when generating candidate ID cards - #113
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for studenthub-staff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the
TypeError: Cannot read properties of undefined (reading 'operation')that occurred during ID card generation incandidate-list.page.ts.The root cause was identified as
CandidateIdCardService.generate()incorrectly using_authhttp.generateCards(), a method designed for blob downloads, which resulted inundefinedbeing returned to the subscriber. The calling component expected a JSON response containing an 'operation' field.The fix involves updating
src/app/providers/logged-in/candidate.id.card.service.tsto use_authhttp.post()instead of_authhttp.generateCards()within thegenerate()method. This ensures that the correct JSON response from the API is received and processed by the subscriber, aligning its behavior with other similar methods in the service.This change aligns with the proposed fix in the unmerged PR #109.
Fixes SH-STAFF-APP-M
Fixes TECH-2165
This PR was automatically generated by Sentry. You can adjust this setting at any time.