This repository was archived by the owner on Feb 21, 2024. It is now read-only.
chore(github-actions): add github actions to this repo#42
Open
svsalvador wants to merge 1 commit intomasterfrom
Open
chore(github-actions): add github actions to this repo#42svsalvador wants to merge 1 commit intomasterfrom
svsalvador wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 95 95
=========================================
Hits 95 95 Continue to review full report at Codecov.
|
svsalvador
requested review from
a team,
adrigzr,
cmatilla,
etarancon,
eumendoza,
josex2r,
julianperezsampedro16 and
xe21500
etarancon
approved these changes
Mar 1, 2021
adrigzr
suggested changes
Mar 2, 2021
| ${{ runner.os }}- | ||
|
|
||
| # Install environment | ||
| - run: npm config set spin false |
Contributor
There was a problem hiding this comment.
I prefer block run step:
- name: Install environment
run: |
npm config set spin false
npm install -g npm@7
npm install -g codecov
npm --version
With this, we can also remove comments for name field.
| name: Check ember-try for [${{matrix.scenario}}] | ||
| strategy: | ||
| matrix: | ||
| scenario: [ember-lts-2.18, ember-lts-3.4, ember-release, ember-beta, ember-default-with-jquery] |
Contributor
There was a problem hiding this comment.
Can we dump this matrix into another yaml and reuse it in all workflows?
adrigzr
reviewed
Mar 3, 2021
| - run: npm run lint:js | ||
| - run: npm run lint:hbs | ||
| - run: npm test | ||
| - run: codecov --file=coverage/node/lcov.info |
Contributor
There was a problem hiding this comment.
I think we can use this action here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.