Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I've added the missing
Add-NetUserfunction to the powerview PowerShell script, it seems to have gotten removed in 12138db. I've also updated theadd_netuser.yamlfile by removing the documentation stating an Empire stager is executed at logon for the newly created user (theAdd-NetUserfunction doesn't do this). I've removed theListenerparameter because it caused the function to crash since it's not in its parameter list and modifiedneeds_adminto betruesince the function requires administrative privileges to successfully execute.I've manually tested the modified module and it is working.
Issue ticket number and link (if there is one)
Checklist before requesting a review
CHANGELOG.mddocs/(if applicable)