BHoM_Engine: Fix issues with system types from newer runtimes to older #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe method That method is handlign far more than just oM classes. Should be used for other types as well. Only keeping the check for IsEngineNamespace as that still should work fine
Changing from checking that the string ends with & to instead contains to handle the case of qualified ref type
and if so, simply try to create it before running into the rest of all the checks
…matic in terms of deserialisation
IsakNaslundBh
requested review from
adecler,
FraserGreenroyd and
al-fisher
as code owners
IsakNaslundBh
requested review from
pawelbaran and
adecler
and removed request for
al-fisher,
adecler and
FraserGreenroyd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3487
Fix issues with types failing to deserialise in newer runtimes.
BHoM_Engine/Serialiser_Engine/Compute/Deserialise/Type.cs
Line 49 in 216ed5f
Test files
Test file on SharePoint
Changelog
Additional comments
Re-opening based on develop, as other was intended to be done as hotfix and was based on main.
Now that strategy is changed, wanted to re-open to keep commit history clean without deployment commits.