Skip to content

Conversation

@peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 5, 2025

Issues addressed by this PR

Closes #3
Closes #5

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EcdzXZ_yVRxIoXTzSqjS1aIB2f6Muyeb8mpQHLaTazwXUA?e=NvhFaA
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SQLite_Toolkit/%233-SupportForNaN/NaNHandling.gh?csf=1&web=1&e=YGgxNJ

Changelog

  • Added support for NaN values, these are not supported in SQLite;
  • AddedNaNHandlingStrategy in SQLiteSettings to determine how to handle NaN values - this is either storing it as a NULL or storing as 0.
  • Added handling for IComparable types (that are typically primitive in the BHoM) allowing them to be pushed and pulled;
  • If the IComparable data is an object, it will be pushed as string as a fallback.

Additional comments

This is especially important for IResult and there can be NaN values present when reading from adapters.

@peterjamesnugent peterjamesnugent self-assigned this Sep 5, 2025
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Sep 5, 2025
@peterjamesnugent peterjamesnugent changed the title Sq lite toolkit #3 handling na n values Add handling for NaN values Sep 5, 2025
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2025

This repository is not part of the beta package and does not require a versioning check to be performed.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2025

This repository is not part of the installer package, and does not require an installer check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add handling for IComparable Add handling for NaN values

2 participants