generated from BHoM/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 0
Add handling for NaN values #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterjamesnugent
wants to merge
9
commits into
develop
Choose a base branch
from
SQLite_Toolkit-#3-HandlingNaNValues
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@BHoMBot check required |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
This repository is not part of the beta package and does not require a versioning check to be performed. |
|
This repository is not part of the installer package, and does not require an installer check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3
Closes #5
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EcdzXZ_yVRxIoXTzSqjS1aIB2f6Muyeb8mpQHLaTazwXUA?e=NvhFaA
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SQLite_Toolkit/%233-SupportForNaN/NaNHandling.gh?csf=1&web=1&e=YGgxNJ
Changelog
NaNvalues, these are not supported inSQLite;NaNHandlingStrategyinSQLiteSettingsto determine how to handleNaNvalues - this is either storing it as aNULLor storing as 0.IComparabletypes (that are typically primitive in the BHoM) allowing them to be pushed and pulled;IComparabledata is an object, it will be pushed asstringas a fallback.Additional comments
This is especially important for
IResultand there can beNaNvalues present when reading from adapters.