Skip to content

Conversation

@IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Sep 26, 2025

Issues addressed by this PR

Branch where I have investigated getting Test projects set up in Test_Toolkit to help run various checks to be used with GithubActions.

Currently covering:

  • Compliance
  • Serialsiation
  • Unit test datasets

Also have a initial skeleton of a yaml workflow file. That yeaml file will need to be updated to incorporate steps of building the toolkit (as well as the dependecies (BHoM/BHoM_Engine/BHoM_Adapter)
This building step can hopefully be achieved relying on build artefacts from those repos.

I have tried to clean up som of the code from my experiments, but there are more cleanup to be done before this is fully merge ready.

Also BEFORE MERGE

  • Fix the yaml file to actually build the code
  • Remove all commited dlls for Build fodler as well as StartupHook

Test files

Changelog

Additional comments

Other issues I have not yet fixed:

Compilation warning for System.Runtime.CompilerServices.Unsafe

I did not bump the nuget package used in the CodeComplianceTest_ENgine
image

This is causing a miss-match For the System.Runtime.CompilerServices.Unsafe package.
the 5.0 version is required for Mongo Bson.

Could potentially just bump the package used, I simply run out of time to check this.

… and Engine to netstandard

Also cleanup unused nugets and update nugets to latest version
…ke use of startup hook

This enables loading of BHoM asseblies from the correct folder (BHoM/Assemblies) without maing local copies.

This is critical to ensure the exact same dll is referenced, for example, the _same_ BHoM dll, which is critical for when for example filtering for if an obejct is an IObject
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 26, 2025
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants