-
Notifications
You must be signed in to change notification settings - Fork 0
Test toolkit investigate running all checks through n unit #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IsakNaslundBh
wants to merge
63
commits into
develop
Choose a base branch
from
Test_Toolkit-InvestigateRunningAllChecksThroughNUnit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test toolkit investigate running all checks through n unit #531
IsakNaslundBh
wants to merge
63
commits into
develop
from
Test_Toolkit-InvestigateRunningAllChecksThroughNUnit
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling of deserialisation errors for UTs
… and Engine to netstandard Also cleanup unused nugets and update nugets to latest version
…as individual tests
…ke use of startup hook This enables loading of BHoM asseblies from the correct folder (BHoM/Assemblies) without maing local copies. This is critical to ensure the exact same dll is referenced, for example, the _same_ BHoM dll, which is critical for when for example filtering for if an obejct is an IObject
Mostly cosmetic to make tests look a bit nicer
…ig file. Make use for project complaicne and assembly info compliance. Tweaks to csFile compliance
Cant use acronym folder name for programdata could not get relative paths to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Branch where I have investigated getting Test projects set up in Test_Toolkit to help run various checks to be used with GithubActions.
Currently covering:
Also have a initial skeleton of a yaml workflow file. That yeaml file will need to be updated to incorporate steps of building the toolkit (as well as the dependecies (BHoM/BHoM_Engine/BHoM_Adapter)
This building step can hopefully be achieved relying on build artefacts from those repos.
I have tried to clean up som of the code from my experiments, but there are more cleanup to be done before this is fully merge ready.
Also BEFORE MERGE
Test files
Changelog
Additional comments
Other issues I have not yet fixed:
Compilation warning for System.Runtime.CompilerServices.Unsafe
I did not bump the nuget package used in the CodeComplianceTest_ENgine

This is causing a miss-match For the System.Runtime.CompilerServices.Unsafe package.
the 5.0 version is required for Mongo Bson.
Could potentially just bump the package used, I simply run out of time to check this.