Fix: track_particles with 1 particle
#1251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can in principle allow to run with `1` particle in `track_particles()`, even though we do have the `track_reference(ref)` mode now. As long as no space charge and no CSR/wakefield effects are requested, this is still a valid configuration. This PR removes an old assert, for which we have a more specific assert in the space charge routines, if enabled. Additionally, it adds a new check into the `HandleWakefield` routines (for CSR), which also rely on a non-flat beam to model anything sensible. Other routines we have, notably ISR, are modeled on individual particles and need no asserts.
ax3l
added
bug
Message changed.
cemitch99
reviewed
Dec 18, 2025
cemitch99
reviewed
Dec 18, 2025
Co-authored-by: Chad Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can in principle allow to run with
1particle intrack_particles(), even though we do have thetrack_reference(ref)mode now: https://impactx.readthedocs.io/en/25.12/usage/how_to_run.html#how-to-select-a-tracking-modeAs long as no space charge and no CSR/wakefield effects are requested, this is still a valid configuration.
This PR removes an old assert, for which we have a more specific assert in the space charge routines, if enabled. Additionally, it adds a new check into the
HandleWakefieldroutines (for CSR), which also rely on a non-flat beam to model anything sensible.Other routines we have, notably ISR, are modeled on individual particles and need no asserts.
First seen in #44 (comment)