Element Push: Restructure #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an overarching particle container push operator to each element. This one by default pushes the reference particle and then the particle beam, as before.
ax3l
commented
Mar 23, 2023
Comment on lines
+31
to
+33
| Programmable (amrex::ParticleReal ds=0.0, int nslice=1) | ||
| : m_ds(ds), m_nslice(nslice) | ||
| {} |
There was a problem hiding this comment.
These constructor arguments were forgotten to be exposed earlier.
The default arguments default to the prior signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element Push: Restructure
Add an overarching particle container push operator to each element. This one by default pushes the reference particle and then the particle beam, as before.
Purpose
This is a preparation for diagnostics in #299 and ML elements, which will operate on the whole particle container. It's also a preparation to simplify the bug fixes introduced for elements with dynamically allocated state from #320.