Skip to content

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 24, 2023

Tests

Check created files with openPMD-validator to conform with the openPMD-standard.

Fixes

Add the positionOffset record of openPMD, which can be used for coarse particle positions or general offsets of a particle species.
This refers now to the offset added by the reference particle.

Follow-up to #299

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: diagnostics all types of outputs labels Apr 24, 2023
@ax3l ax3l force-pushed the fix-openPMD-metadata branch from b3e4954 to 8dce959 Compare April 24, 2023 18:02
Check created files with `openPMD-validator` to conform
with the `openPMD-standard`.
@ax3l ax3l force-pushed the fix-openPMD-metadata branch from 8dce959 to ba83cf3 Compare April 24, 2023 20:59
@ax3l ax3l requested a review from cemitch99 April 24, 2023 21:54
Comment on lines +264 to +265
beam["positionOffset"]["ct"].resetDataset(d_fl);
beam["positionOffset"]["ct"].makeConstant(ref_part.t);
Copy link
Member Author

@ax3l ax3l Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cemitch99 here for positionOffset and in position, do we want to output s+delta s instead of ct + c*dt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow what the intended output is here. I understand that by "ct" you mean "ref_part.t", but what is meant by "dt"? Does this represent one or more particle values of the "t" coordinate?

In general, I would say that "s" is qualitatively different from the other variables like ct. It is an independent variable, it is associated only with the reference particle, and the other (beam particle) values are given as functions of "s".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ah yes I was confused for a second... So per particle, splitting the longitudinal position (for a fixed s) into ref_part.t (should we call this ref_part.ct?) and position.ct makes sense...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do in #350

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me, thanks.

@ax3l ax3l force-pushed the fix-openPMD-metadata branch from 3f978de to c07eb30 Compare April 25, 2023 01:10
@ax3l ax3l force-pushed the fix-openPMD-metadata branch from c07eb30 to 03769f2 Compare April 25, 2023 01:47
@ax3l ax3l merged commit 27af60c into BLAST-ImpactX:development Apr 25, 2023
@ax3l ax3l deleted the fix-openPMD-metadata branch April 25, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: diagnostics all types of outputs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants