-
Notifications
You must be signed in to change notification settings - Fork 29
Fix openPMD Meta-Data #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3e4954
to
8dce959
Compare
Check created files with `openPMD-validator` to conform with the `openPMD-standard`.
8dce959
to
ba83cf3
Compare
beam["positionOffset"]["ct"].resetDataset(d_fl); | ||
beam["positionOffset"]["ct"].makeConstant(ref_part.t); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cemitch99 here for positionOffset
and in position
, do we want to output s
+delta s
instead of ct
+ c*dt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow what the intended output is here. I understand that by "ct" you mean "ref_part.t", but what is meant by "dt"? Does this represent one or more particle values of the "t" coordinate?
In general, I would say that "s" is qualitatively different from the other variables like ct. It is an independent variable, it is associated only with the reference particle, and the other (beam particle) values are given as functions of "s".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, ah yes I was confused for a second... So per particle, splitting the longitudinal position (for a fixed s) into ref_part.t
(should we call this ref_part.ct
?) and position.ct
makes sense...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do in #350
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok to me, thanks.
3f978de
to
c07eb30
Compare
pipe arguments
c07eb30
to
03769f2
Compare
Tests
Check created files with
openPMD-validator
to conform with theopenPMD-standard
.Fixes
Add the
positionOffset
record of openPMD, which can be used for coarse particle positions or general offsets of a particle species.This refers now to the offset added by the reference particle.
Follow-up to #299