pytest-benchmark for all elements #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
Performance optimization
component: tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
commented
Jun 10, 2025
Useful to attach more data at Python runtime to the `sim` object.
This set of tests is used for performance benchmarking of individual elements pushes (as micro-benchmarks). We use this file to rapidly evaluate performance changes when tuning beamline element performance on CPUs and GPUs.
ax3l
commented
Jun 18, 2025
ax3l
commented
Jun 18, 2025
|
|
||
| def test_ThinDipole(benchmark, sim): | ||
| el = elements.ThinDipole(name="kick", theta=0.45, rc=1.0) | ||
| benchmark.pedantic(el.push, setup=partial(pc_setup, sim), rounds=rounds) |
Member
Author
There was a problem hiding this comment.
We could add a post-benchmark validation that:
- particles where not marked as invalid (e.g., turned out)
- no inf/nan is present in the pushed particle beam attributes
cemitch99
reviewed
Jun 18, 2025
cemitch99
reviewed
Jun 18, 2025
cemitch99
reviewed
Jun 18, 2025
cemitch99
approved these changes
Jun 18, 2025
Member
cemitch99
left a comment
cemitch99
left a comment
There was a problem hiding this comment.
I suggested a simplification of the beam energy/distribution inputs. I think it's ok to leave the element parameters unchanged (from the originating examples). Otherwise, it looks good to me.
Co-authored-by: Chad Mitchell <[email protected]>
Member
Author
|
ouch, because we did not release ImpactX yet, this relies on post 25.06 changes #993 in pyAMReX/WarpX -. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of tests is used for performance benchmarking of individual elements pushes (as micro-benchmarks). We use this file to rapidly evaluate performance changes when tuning beamline element performance on CPUs and GPUs.
This integrates seamless with our pytest tests, e.g., to run only the benchmark tests (after
pip_install):python -m pytest tests/python/test_benchmark_elements.pyThere are additional command line flags for saving outputs and comparing them in the pytest-benchmark documentation.
Depends on:
AddParticles(pc & other)Broken in ImpactX AMReX-Codes/amrex#4498