-
Notifications
You must be signed in to change notification settings - Fork 202
[WIP] Output More Versions #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
@cyrush is there an "include + macro / runtime API query" way to query the version of Ascent/Conduit? :) @c-wetterer-nelson s there an "include + macro / runtime API query" way to query the version of SENSEI? :) @mgates3 is there an "include + macro / runtime API query" way to query the version of BLAS++/LAPACK++? :) |
4b26e8e
to
52fe92d
Compare
Add more build information and dependency information to our output on startup. This increases reproducibility by tracking more software dependendencies and build options.
52fe92d
to
12c5233
Compare
@@ -110,9 +111,7 @@ WarpX::InitData () | |||
{ | |||
WARPX_PROFILE("WarpX::InitData()"); | |||
Print() << "WarpX (" << WarpX::Version() << ")\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are changing this, can the version information be printed earlier? A number of things happen before WarpX::InitData
is called and if something goes wrong there, the version info won't be output. A user I'm working with has a case where a problem is happening in ParseGeometryInput
for example and there is no version info to help debug it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move our info definitely up. Only the AMReX info will first be printed here, I think.
@ax3l yes, here is an example of how to get the ascent version:
|
@@ -316,6 +316,19 @@ if(WIN32) | |||
target_compile_definitions(ablastr PUBLIC _USE_MATH_DEFINES) | |||
endif() | |||
|
|||
# additional defines for version outputs | |||
# CMake | |||
target_compile_definitions(ablastr PUBLIC CMAKE_VERSION=${CMAKE_VERSION}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also use
set_property(SOURCE source.cpp PROPERTY COMPILE_DEFINITIONS
VAR1=${MY_VAR1} VAR2=${MY_VAR2})
for ablastr/version/VersionFormat.cpp
#endif | ||
|
||
#if defined(AMREX_USE_OMP) | ||
std::map< int, std::string > mapOpenMP = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::map< int, std::string > mapOpenMP = { | |
std::map< int, std::string > const mapOpenMP = { |
Found this buried in my inbox. @ax3l Yes, BLAS++ and LAPACK++ have C++ macros BLASPP_VERSION and LAPACKPP_VERSION, and also runtime functions blaspp_version() and lapackpp_version().
Incidentally, we released those versions last month. |
Add more build information and dependency information to our output on startup. This increases reproducibility by tracking more software dependencies and build options.
Example output when built with CMake: