-
Notifications
You must be signed in to change notification settings - Fork 202
Read wavelength and flag 'isLaserEnvelope' from lasy file #3957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IlianCS
wants to merge
62
commits into
BLAST-WarpX:development
Choose a base branch
from
IlianCS:lasy_wavelength
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
cc @MaxThevenet @RemiLehe I think this might need an addition of a few attributes in the openPMD laser envelope extension? Did we already start discussing this, sounds like a good idea :) https://github.com/openPMD/openPMD-standard/blob/upcoming-2.0.0/EXT_LaserEnvelope.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next implementations for lasy files reading, following #3910
Files that need to be changed:
Originally we wanted to read the wavelength, polarization and e_max from the lasy file. We also wanted to read the full field if isLaserEnvelope is set to False in the file.
Update: We are not looking for reading the polarization and e_max in the file anymore.
e_max: we are waiting for e_max to be stored inside the lasy file because we don't want to loop over the whole file in WarpX in order to compute it.
polarization: complex meta data set by the user when creating a lasy file to define, for instance, circular and elliptical lasers. As WarpX is not able to read complex polarization, we cannot read this attribute so we let it as a choice for the user to provide a linear polarization in the inputs file.
isLaserEnvelope: we want to read the boolean inside the lasy file but lasy does not have the capability yet to store the amplitude instead of the envelope.
TODO list (updated):