Add test for MR with 2 levels #3979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The results of the test look correct, but the error (~5%) is slightly too high at this point. |
RemiLehe
changed the title
Member
|
attn @WeiqunZhang @atmyers |
Member
|
@RemiLehe oops, looks like this does not pass the test it adds. Can you please rebase and check? :) |
ax3l
changed the title
Co-authored-by: Remi Lehe <[email protected]>
ax3l
changed the title
ax3l
approved these changes
Dec 2, 2025
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Ok, the changes were small:
A tiny relaxation of the threshold for the analytical solution.
I added a checksum and the values on level 0 and 1 are also reasonably close to the 1 level MR case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #3777 is merged, it should be possible to do simulations with 2 levels of refinement.