Add LabFrameParticleDiagnostic to picmi #4148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
component: PICMI
ax3l
reviewed
Aug 28, 2023
| @@ -2212,16 +2215,19 @@ class LabFrameFieldDiagnostic(picmistandard.PICMI_LabFrameFieldDiagnostic, | |||
|
|
|||
| warpx_upper_bound: vector of floats, optional | |||
| Passed to <diagnostic name>.upper_bound | |||
|
|
|||
| warpx_write_species: bool, optional, default=True | |||
There was a problem hiding this comment.
In PICMI, I think it makes more sense to turn them off by default...
Suggested change
| warpx_write_species: bool, optional, default=True | |
| warpx_write_species: bool, optional, default=False |
ax3l
reviewed
Aug 28, 2023
| warpx_buffer_size: integer, optional | ||
| Passed to <diagnostic name>.buffer_size | ||
|
|
||
| warpx_write_fields: bool, optional, default=True |
There was a problem hiding this comment.
Suggested change
| warpx_write_fields: bool, optional, default=True | |
| warpx_write_fields: bool, optional, default=False |
ax3l
reviewed
Aug 28, 2023
Comment on lines
+2295
to
+2297
| for more information. | ||
|
|
||
| This will by default write out both field and particle data. This can be changed by setting warpx_write_fields. |
There was a problem hiding this comment.
Suggested change
| for more information. | |
| This will by default write out both field and particle data. This can be changed by setting warpx_write_fields. | |
| for more information. |
ax3l
reviewed
Aug 28, 2023
Comment on lines
+2192
to
+2194
| for more information. | ||
|
|
||
| This will by default write out both field and particle data. This can be changed by setting warpx_write_species. |
There was a problem hiding this comment.
Suggested change
| for more information. | |
| This will by default write out both field and particle data. This can be changed by setting warpx_write_species. | |
| for more information. |
ax3l
reviewed
Aug 28, 2023
| self.format = kw.pop('warpx_format', None) | ||
| self.openpmd_backend = kw.pop('warpx_openpmd_backend', None) | ||
| self.file_prefix = kw.pop('warpx_file_prefix', None) | ||
| self.file_min_digits = kw.pop('warpx_file_min_digits', None) | ||
| self.buffer_size = kw.pop('warpx_buffer_size', None) | ||
| self.lower_bound = kw.pop('warpx_lower_bound', None) | ||
| self.upper_bound = kw.pop('warpx_upper_bound', None) | ||
| self.write_species = kw.pop('warpx_write_species', None) |
There was a problem hiding this comment.
Suggested change
| self.write_species = kw.pop('warpx_write_species', None) | |
| self.write_species = kw.pop('warpx_write_species', False) |
ax3l
reviewed
Aug 28, 2023
| self.file_prefix = kw.pop('warpx_file_prefix', None) | ||
| self.file_min_digits = kw.pop('warpx_file_min_digits', None) | ||
| self.buffer_size = kw.pop('warpx_buffer_size', None) | ||
| self.write_fields = kw.pop('warpx_write_fields', None) |
There was a problem hiding this comment.
Suggested change
| self.write_fields = kw.pop('warpx_write_fields', None) | |
| self.write_fields = kw.pop('warpx_write_fields', False) |
|
We can address my comments in #3207 |
ax3l
approved these changes
Aug 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that with
LabFrameParticleDiagnosticorLabFrameFieldDiagnostic, both the particles and fields will be written out. Each has a flag to turn the other off. This is the same way that the regular diagnostics are setup.