[WIP] Add PICMI interface for BoundaryScrapingDiagnostic #4383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
commented
Oct 17, 2023
| """ | ||
| def init(self, kw): | ||
|
|
||
| self.format = kw.pop('warpx_format', 'plotfile') |
There was a problem hiding this comment.
These parts should be in the base class, as they are used across many diagnostics.
RemiLehe
commented
Oct 17, 2023
| self.diagnostic.openpmd_backend = self.openpmd_backend | ||
| self.diagnostic.file_min_digits = self.file_min_digits | ||
| self.diagnostic.intervals = self.period | ||
| self.diagnostic.particles_at_eb = 1 |
There was a problem hiding this comment.
This should be in a parent PICMI class
RemiLehe
commented
Oct 17, 2023
|
|
||
| # --- Use a set to ensure that fields don't get repeated. | ||
| variables = set() | ||
|
|
There was a problem hiding this comment.
The code below should be in the WarpXDiagnostic parent class, since it is used across many diagnostics
ax3l
added
component: Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.