Add a thermal plasma flux #4486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Update pybind11 to the latest release.
* Set alpha mass directly from NIST data * Delete extra line
…ates (BLAST-WarpX#4481) * Add `latex_theory/allbibs.bib` to conf.py * Delete additional redundant reference and make intro.rst match intro.tex
It appears that we need to call brew upgrade.
Unlike std::sqrt that has overloads for double and float, sqrt is a C function that takes a double. If the argument is a float, it will have to be promoted to double first.
For performance and readability, instead of including checks explicitly, switch to excluding checks explicitly. These checks are excluded because currently WarpX fails at them. Add portability and diagnostic checks.
Add `--keep-going` to the make command in Clang-Tidy CI. With that, the job will keep going and show all the clang-tidy check errors instead of stopping on the first error.
* move external field parameters into a dedicated class * add full header in Python/WarpX.cpp * fix bug introduced in Make.package * enforce inputfile syntax * fix issue found with clang-tidy * remove unwanted includes * added missing include * replace init function with constructor * update doc * fix bug and add curly braces
updates: - [github.com/pycqa/isort: 5.12.0 → 5.13.0](PyCQA/isort@5.12.0...5.13.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* bib-formatting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Rename bib style class * Delete unused imports * Add comments to conf.py * Tweaks to .bib files * Add pybtex to Doc requirements * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* AMReX: Weekly Update * pyAMReX: Weekly Update * Python: Update breaking APIs Functions are now upstream and properties.
…CI test (BLAST-WarpX#4496) * enable readability-duplicate-include check in clang-tidy CI test * remove duplicate includes
* Force user to select helium4 in the p-B fusion reaction * Update helium4 mass in fusion module and tests * Replace proton with hydrogen1 * Update hydrogen1 mass in fusion module and tests * Update benchmarks
* AMReX: Weekly Update * pyAMReX: Weekly Update
* workflow training neural network from warpx data * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * address automated review comments * Apply suggestions from code review Co-authored-by: Axel Huebl <[email protected]> * move data and figures to cloud (GitHub and Zenodo) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Change to title case * add ml references to bibliography * Formatting * Test other multi-ref * Refs * One more ref * Finalize Ending --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Axel Huebl <[email protected]>
Fixed by clang-tidy --fix.
We know of a few compiler issues for C++17 CUDA code in CUDA <11.7 for a bit, updating Summit and general recommendations.
* Add updated instructions for WarpX on Karolina Use spack for installing all dependencies, and the new slurm scheduler. * Update Tools/machines/karolina-it4i/install_dependencies.sh End for loop Co-authored-by: Axel Huebl <[email protected]>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
This is a really nice feature. Looking forward to seeing it merged! |
archermarx
reviewed
Feb 7, 2024
Contributor
There was a problem hiding this comment.
Is there a reason for the capitalization of PLasmaFluxDistribution (vs PlasmaFluxDistribution)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a method of flux injection where the flux of injected particles is set dynamically so that the grid cells at the plane of injection will always have at least the specified number of particles. The purpose is to provide a stable boundary condition representing an extend thermal plasma.
Todo: