supporting nlev>0 in BTD output #4526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ax3l
added
component: diagnostics
ax3l
reviewed
Dec 15, 2023
| @@ -187,10 +187,10 @@ private: | |||
| amrex::Vector<amrex::IntVect> m_snapshot_ncells_lab; | |||
| /** Vector of Box-dimension in boosted-frame index space | |||
| * for each back-transformed snapshot */ | |||
There was a problem hiding this comment.
Suggested change
| * for each back-transformed snapshot */ | |
| * for each back-transformed snapshot (inner vector) | |
| * and level (outer vector) */ |
| @@ -187,10 +187,10 @@ private: | |||
| amrex::Vector<amrex::IntVect> m_snapshot_ncells_lab; | |||
| /** Vector of Box-dimension in boosted-frame index space | |||
| * for each back-transformed snapshot */ | |||
| amrex::Vector<amrex::Box> m_snapshot_box; | |||
| amrex::Vector< amrex::Vector <amrex::Box> > m_snapshot_box; | |||
| /** Vector of Box-dimension in boosted-frame index space corresponding to the | |||
| * buffer that covers a part of the full backtransformed snapshot */ | |||
There was a problem hiding this comment.
Suggested change
| * buffer that covers a part of the full backtransformed snapshot */ | |
| * buffer that covers a part of the full backtransformed snapshot | |
| * (inner vector) and level (outer vector) */ |
| @@ -238,7 +238,7 @@ private: | |||
| /** Vector of k-indices in the hi-end along the moving window direction for the buffer being filled | |||
| * for each snapshot. | |||
There was a problem hiding this comment.
Suggested change
| * for each snapshot. | |
| * for each snapshot (inner vector) and level (outer vector) */ |
| @@ -307,8 +307,8 @@ private: | |||
| * returns bool = true is buffer is full, that is, | |||
| when buffer counter is equal to m_buffer_size | |||
| */ | |||
| bool buffer_full (int i_buffer) { | |||
| return (k_index_zlab(i_buffer,0) == m_buffer_box[i_buffer].smallEnd(m_moving_window_dir)); | |||
| bool buffer_full (int i_buffer, const int lev) { | |||
There was a problem hiding this comment.
Suggested change
| bool buffer_full (int i_buffer, const int lev) { | |
| bool buffer_full (int i_buffer, int lev) { |
Comment on lines
+415
to
+416
| int get_buffer_k_index_hi (int i_buffer, const int lev) override {return m_buffer_k_index_hi[i_buffer][lev]; } | ||
| void set_buffer_k_index_hi (int i_buffer, int kindex, const int lev) override {m_buffer_k_index_hi[i_buffer][lev] = kindex;} |
There was a problem hiding this comment.
Suggested change
| int get_buffer_k_index_hi (int i_buffer, const int lev) override {return m_buffer_k_index_hi[i_buffer][lev]; } | |
| void set_buffer_k_index_hi (int i_buffer, int kindex, const int lev) override {m_buffer_k_index_hi[i_buffer][lev] = kindex;} | |
| int get_buffer_k_index_hi (int i_buffer, int lev) override {return m_buffer_k_index_hi[i_buffer][lev]; } | |
| void set_buffer_k_index_hi (int i_buffer, int kindex, int lev) override {m_buffer_k_index_hi[i_buffer][lev] = kindex;} |
| @@ -412,8 +412,8 @@ private: | |||
|
|
|||
| amrex::Real gettlab (int i_buffer) override {return m_t_lab[i_buffer];} | |||
There was a problem hiding this comment.
Please add doxygen strings for function use and parameters :)
Comment on lines
+304
to
+310
| auto is_buffer_full = false; | ||
| //const int nlevels = m_particles_buffer[i_buffer][0]->numLevels(); | ||
| for (int lev = 0 ; lev < nmax_lev; ++lev) { | ||
| is_buffer_full = buffer_full(i_buffer, lev); | ||
| } | ||
|
|
||
| // or |
There was a problem hiding this comment.
Formatting indent is off here a bit :)
| @@ -825,9 +835,12 @@ BTDiagnostics::PrepareFieldDataForOutput () | |||
| // and box-indices | |||
| DefineSnapshotGeometry(i_buffer, lev); | |||
| } | |||
| //amrex::Print() << "lev = " << lev << " : DefineFieldBufferMultiFab called -- " << "\n"; | |||
There was a problem hiding this comment.
Suggested change
| //amrex::Print() << "lev = " << lev << " : DefineFieldBufferMultiFab called -- " << "\n"; |
| @@ -801,12 +811,12 @@ BTDiagnostics::PrepareFieldDataForOutput () | |||
| warpx.Geom(lev).periodicity()); | |||
| } | |||
| // Flattening out MF over levels | |||
Comment on lines
+919
to
+920
| //amrex::Print() << "buffer_ba = " << buffer_ba << "\n"; | ||
| //amrex::Print() << "buffer_dmap = " << buffer_dmap << "\n"; |
There was a problem hiding this comment.
Suggested change
| //amrex::Print() << "buffer_ba = " << buffer_ba << "\n"; | |
| //amrex::Print() << "buffer_dmap = " << buffer_dmap << "\n"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken @prkkumar 's PR (#4197)
and modified to include some more bug fixes.
Current status :
BTD field output for multiple levels is now working.