[WIP] Removed assert and allowed bilinear filtering along r with RZ FDTD #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshapoval
changed the title
oshapoval
changed the title
oshapoval
changed the title
oshapoval
changed the title
RemiLehe
reviewed
Mar 25, 2024
| @@ -20,8 +20,7 @@ boundary.field_hi = pec pec | |||
| ################################# | |||
| warpx.verbose = 1 | |||
| warpx.do_dive_cleaning = 0 | |||
| warpx.use_filter = 1 | |||
| warpx.filter_npass_each_dir = 0 1 | |||
| #warpx.use_filter = 1 | |||
There was a problem hiding this comment.
Wouldn't it be better to use use_filter = 1 here, to test the new capability?
There was a problem hiding this comment.
Yes, here we want to use and set warpx.use_filter = 1 explicitly, still needed to clean up after testing. Thank you for spotting this. Fixed in 6d87779.
ax3l
added
component: core
|
@oshapoval can you locally take a look why |
oshapoval
changed the title
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an abort message which prevented from using bilinear filtering for charge and currents on the mesh, along
rwith RZ FDTD. Previously this assert message was added because we had observed strange results in RZ FDTD when filtering was ON ( see #1943 ) that we do not observe anymore.Now, the default is
warpx.use_filter=1in all cases, including the simulations with RZ FDTD solver. Note, with the RZ PSATD solver, the filtering is donek-space.One can also set the number of passes along each direction
warpx.filter_npass_each_dir(3 int), and default is1 1 1.inputs_rz.txt