[WIP] ABLASTR: IntervalsParser & SafeCast #5227
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and move out the `SafeCast` and `IntervalsParser` from WarpX to ABLASTR.
ax3l
commented
Sep 8, 2024
| { | ||
| WARPX_ALWAYS_ASSERT_WITH_MESSAGE(!m_isBTD || !insplit[1].empty(), "must specify interval stop for BTD"); | ||
| if (!insplit[0].empty()){ | ||
| m_start = parseStringtoInt(insplit[0], "interval start");} |
There was a problem hiding this comment.
parseStringtoInt: @WeiqunZhang can I use an AMReX intrinsic for this now?
There was a problem hiding this comment.
I looked at the implementation of that function. It use amrex::Parser to parse it as double precision numbers and then check if it can be safely cast to int. There is amrex::IParser we can use. It parses the numbers as long long. So the chance of overflowing during parsing is tiny. The safety checking for casting to int would also be much simpler.
ax3l
commented
Sep 8, 2024
|
|
||
| ablastr::utils::parser::SliceParser::SliceParser ( | ||
| const std::string& instr, | ||
| const bool isBTD |
There was a problem hiding this comment.
Urgh, such a hack: The isBTD should never have made it into this interface and needs to be removed. BTDIntervalsParser can handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and move out the
SafeCastandIntervalsParserfrom WarpX to ABLASTR.