[Hackathon] Refactor ParserUtils and IntervalsParser #5254
+72
−297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
added
the
hackathon
WeiqunZhang
force-pushed
the
parmparse
branch
from
afb0e9c to
8c3b058
Compare
WeiqunZhang
force-pushed
the
parmparse
branch
3 times, most recently
from
7393868 to
d5fd73c
Compare
Refactor ParserUtils and IntervalsParser by using the new Parser capability in amrex::Parser.
WeiqunZhang
force-pushed
the
parmparse
branch
from
d5fd73c to
13acf59
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ParserUtils and IntervalsParser by using the new Parser capability in amrex::Parser. It's also okay now to use amrex::ParmParse directly because we have added warpx constants to ParmParse for Parser to use (see #5751).