Fix clang-tidy errors in development branch
#5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
aeriforme
approved these changes
Sep 19, 2024
Member
aeriforme
left a comment
aeriforme
left a comment
There was a problem hiding this comment.
Noted, thank you!
I confirm it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #5285, I noticed that #4937 did not pass our 3D clang-tidy check, which is currently failing in
development:Haavaan:heffte)ECP-WarpX:development)The RZ check was skipped due to the 3D one failing, so that might bring up issues too.
The clang-tidy errors fixed so far are:
/home/runner/work/WarpX/WarpX/Source/ablastr/fields/IntegratedGreenFunctionSolver.cpp:196:5: error: variable 'local_boxid' of type 'int' can be declared 'const' [misc-const-correctness,-warnings-as-errors]/home/runner/work/WarpX/WarpX/Source/ablastr/fields/IntegratedGreenFunctionSolver.cpp:201:9: error: variable 'local_nodal_box' of type 'amrex::Box' (aka 'BoxND<3>') can be declared 'const' [misc-const-correctness,-warnings-as-errors]