Rigid injection: Center field scaling around the v push #5389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
commented
Oct 31, 2024
|
|
||
| amrex::ParticleReal* AMREX_RESTRICT x_save = xp_save.dataPtr(); | ||
| amrex::ParticleReal* AMREX_RESTRICT y_save = yp_save.dataPtr(); | ||
| amrex::ParticleReal* AMREX_RESTRICT z_save = zp_save.dataPtr(); |
Member
Author
There was a problem hiding this comment.
Saving and re-setting u to its original value is not needed anymore since the scaling factor for E and B is 0 for particles to the left of the plane.
RemiLehe
force-pushed
the
scale_rigid_injection
branch
from
4b430f1 to
f6e4566
Compare
RemiLehe
changed the title
dpgrote
reviewed
Oct 31, 2024
| // If the particle stays to the left of the plane during the | ||
| // whole push, simply set the scaling factor to 0. | ||
| if (dtscale < 0._rt) { | ||
| dtscale = 0; |
Member
There was a problem hiding this comment.
Perhaps add a comment that since the scale factor is zero, the push of the velocity doesn't change the velocity.
dpgrote
approved these changes
Oct 31, 2024
Member
dpgrote
left a comment
dpgrote
left a comment
There was a problem hiding this comment.
This looks good. I approve, but have one suggestion for a comment to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rigid injection, the fields where scale by the fraction of time spent between
n*dtand(n+1)*dtto the right of the injection plane. However, to be consistent with the leap-frog velocity update, this needs to be between(n-1/2)*dtand(n+1/2)*dtinstead.As a side-effect of this PR, saving and re-setting
uandoptical_depthto their original value is not needed anymore since the scaling factor for E and B is 0 for particles to the left of the plane.