Skip to content

CTest: fix bug with WarpX_APP=OFF and WarpX_PYTHON=ON #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

CTest: fix bug with WarpX_APP=OFF and WarpX_PYTHON=ON #5421

merged 1 commit into from
Oct 29, 2024
+5 −0

Conversation

@EZoni
Copy link
Member

@EZoni EZoni commented Oct 29, 2024

Our CMakeLists to set up the ctest executable had a logic error when WarpX_APP=OFF and WarpX_PYTHON=ON, in that it was trying to install executable tests without an executable application.

The error message looked something like

  Error evaluating generator expression:
    $<TARGET_FILE:app_3d>
  No target "app_3d"

@EZoni EZoni added bug Something isn't working component: tests Tests and CI bug: affects latest release Bug also exists in latest release version labels Oct 29, 2024
@EZoni EZoni requested review from RemiLehe and WeiqunZhang October 29, 2024 01:17
@RemiLehe RemiLehe enabled auto-merge (squash) October 29, 2024 13:22
@RemiLehe RemiLehe disabled auto-merge October 29, 2024 13:22
@RemiLehe RemiLehe merged commit 026e093 into BLAST-WarpX:development Oct 29, 2024
32 checks passed
@EZoni EZoni deleted the ctest_fix_warpx_app branch October 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemiLehe RemiLehe RemiLehe approved these changes

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees

No one assigned

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: tests Tests and CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EZoni @RemiLehe