Added AnalyticFluxDistribution class #5422
Conversation
for more information, see https://pre-commit.ci
…shapoval/WarpX into add_analytic_flux_distribution
Python/pywarpx/picmi.py
Outdated
| species.add_new_group_attr(source_name, "density", density_scale) | ||
|
|
||
|
|
||
| class AnalyticFluxDistribution( |
There was a problem hiding this comment.
Is there a different way to handle this? This is an exact duplicate of UniformFluxDistribution except for the one keyword argument flux_expression.
This could be simplified if the picmistandard class took the same argument, flux, as the uniform distribution, then one could do "UniformFluxDistribution = AnalyticFluxDistribution" and have only one version of the class.
There was a problem hiding this comment.
Good point.
Note that we also have two different classes for the volume injection: UniformDistribution and AnalyticDistribution, so we were trying to mirror the same setup here for UniformFluxDistribution and AnalyticFluxDistribution.
Do you think that your comment also applies to UniformDistribution and AnalyticDistribution?
There was a problem hiding this comment.
Thanks for pointing this out, I will refactor accordingly.
There was a problem hiding this comment.
The UniformDistribution and AnalyticDistribution are quite a bit different from each other and it's probably too late to change that API.
There was a problem hiding this comment.
Is this PR ready? I still see the duplication of 'UniformFluxDistribution' - this is fine if that is the intent. Also, UniformFluxDistribution has the inject_from_embedded_boundary option - would that also be supported with the analytic distribution?
…be parsed as a function
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…shapoval/WarpX into add_analytic_flux_distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
3 participants
Added an AnalyticFluxDistribution class with a parsed
flux_expression. Depends on picmi-standard/picmi#121