Skip to content

Fix dt_update_interval argument to ElectrostaticSolver #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fix dt_update_interval argument to ElectrostaticSolver #5434

merged 3 commits into from
Nov 4, 2024

Conversation

@dpgrote
Copy link
Member

@dpgrote dpgrote commented Oct 31, 2024 •
edited
Loading

The warpx prefix was left off of this argument.

This addresses issues raised in #5431 and #5432

@dpgrote dpgrote added component: PICMI Standardized input format bug: affects latest release Bug also exists in latest release version labels Oct 31, 2024
@dpgrote dpgrote marked this pull request as ready for review October 31, 2024 17:08
@dpgrote dpgrote mentioned this pull request Oct 31, 2024
Closed
@archermarx
Copy link
Contributor

archermarx commented Nov 4, 2024

Thanks for the catch!

@archermarx archermarx self-requested a review November 4, 2024 17:09
@roelof-groenewald roelof-groenewald linked an issue Nov 4, 2024 that may be closed by this pull request
Documentation error, and possible bug, for Electrostatic solver #5432
Closed
roelof-groenewald
roelof-groenewald approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@roelof-groenewald roelof-groenewald merged commit a62a227 into BLAST-WarpX:development Nov 4, 2024
37 checks passed
@dpgrote dpgrote deleted the fix_picmi_warpx_dt_update_interval branch November 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roelof-groenewald roelof-groenewald roelof-groenewald approved these changes

+1 more reviewer

@archermarx archermarx archermarx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug: affects latest release Bug also exists in latest release version component: PICMI Standardized input format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation error, and possible bug, for Electrostatic solver

3 participants

@dpgrote @archermarx @roelof-groenewald