Skip to content

Conversation

@RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Nov 4, 2024

I forgot to update the comment in this PR:
#5335

@RemiLehe RemiLehe requested a review from aeriforme November 4, 2024 19:55
@aeriforme
Copy link
Member

Ok, but why don't we copy the ghost cells?
From here I see that the reason is that otherwise ImpactX wouldn't converge. Do we know why though?

@RemiLehe RemiLehe merged commit bae146f into BLAST-WarpX:development Nov 4, 2024
37 checks passed
@RemiLehe
Copy link
Member Author

RemiLehe commented Nov 4, 2024

@aeriforme This is still being investigated, but in the meantime, I think we want to keep the comments in sync with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants