Revert "Python: Warn old warpx.multifab Signature (#5326)"
#5452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the changes of #5326 is causing confusion among some users.
With #5326, users typically receive a message saying that the "signature is deprecated" (which is actually incorrect ; this should say "will soon be deprecated"). As a consequence, users think that their simulation result is invalid (which is again incorrect ; using this signature is still fine for now), and try to change it according the printed instuctions, i.e.:
But because there is no link to a concrete example or test, users typically try:
and then get
I am guessing that most users will get stuck at this point.
The error message does suggest that the user has to create a
Directionobject, but since there is no example on how to create this, it is unlikely that most users will be able to overcome this issue.I would suggest to temporarily revert #5326, and then re-introduce it with:
Directionobjects