Skip to content

Conversation

@EZoni
Copy link
Member

@EZoni EZoni commented Apr 7, 2025

Weekly update to latest AMReX, pyAMReX, PICSAR:

./Tools/Release/updateAMReX.py
./Tools/Release/updatepyAMReX.py
./Tools/Release/updatePICSAR.py

New WarpX release 25.04:

./Tools/Release/newVersion.sh

@EZoni EZoni added the component: third party Changes in WarpX that reflect a change in a third-party library label Apr 7, 2025
@EZoni EZoni changed the title Weekly Update to Latest AMReX, pyAMReX, PICSAR Weekly Update, Release 25.04 Apr 7, 2025
@EZoni EZoni requested a review from a team April 7, 2025 16:52
@EZoni

This comment was marked as resolved.

@EZoni EZoni changed the title Weekly Update, Release 25.04 [WIP] Weekly Update, Release 25.04 Apr 7, 2025
@EZoni EZoni changed the title [WIP] Weekly Update, Release 25.04 Weekly Update, Release 25.04 Apr 8, 2025
@EZoni
Copy link
Member Author

EZoni commented Apr 8, 2025

I suggest that we wait for AMReX-Codes/amrex#4407 to be merged and then rerun the update here to include that bug fix, which is needed in other open PRs, e.g., #5768.

@EZoni
Copy link
Member Author

EZoni commented Apr 9, 2025

@WeiqunZhang @atmyers

Are you aware of any recent changes in AMReX that could explain the fact that the checksums of the following 3D tests seem to need an update?

The following tests FAILED:
	273 - test_3d_particle_absorption.checksum (Failed)
	277 - test_3d_particle_scrape.checksum (Failed)
	281 - test_3d_particle_scrape_picmi.checksum (Failed)
	429 - test_3d_eb_picmi.checksum (Failed)
Errors while running CTest

I am thinking about changes (e.g., bug fixes) since the March release (we skipped a few updates), such as, for example,

@EZoni EZoni requested review from WeiqunZhang and atmyers April 9, 2025 22:32
@WeiqunZhang
Copy link
Member

Yes the EB change may cause roundoff errors. The other two are not bugs that change the solution. One is like instead of checking n < something, where n is 0, 1, 2, ..., it only checkes n = 0. The other is a harmless bug that could trigger fpe.

@EZoni
Copy link
Member Author

EZoni commented Apr 10, 2025

Thanks for the update, @WeiqunZhang.

The relative errors seem larger than roundoff in some cases. But I guess the magnitude of those may depend on the resolution of the test and other factors as well.

I will push a commit to fetch the latest commit before AMReX-Codes/amrex#4357 in order to verify that the checksums changes seen here are indeed due to that bug fix. If that is the case, I will push the back the update and reset the checksums.

@EZoni EZoni changed the title Weekly Update, Release 25.04 [WIP] Weekly Update, Release 25.04 Apr 10, 2025
@EZoni
Copy link
Member Author

EZoni commented Apr 10, 2025

With 67c23ab, fetching the latest commit before AMReX-Codes/amrex#4357, all checksums pass:
https://dev.azure.com/BLAST-WarpX/WarpX/_build/results?buildId=292&view=results.

Now testing ab8d4d8, fetching the merge commit of AMReX-Codes/amrex#4357...
https://dev.azure.com/BLAST-WarpX/WarpX/_build/results?buildId=294&view=results.

The following tests FAILED:
	273 - test_3d_particle_absorption.checksum (Failed)
	277 - test_3d_particle_scrape.checksum (Failed)
	281 - test_3d_particle_scrape_picmi.checksum (Failed)
	429 - test_3d_eb_picmi.checksum (Failed)
Errors while running CTest

The checksums changes seem to be caused indeed by AMReX-Codes/amrex#4357.

@EZoni EZoni changed the title [WIP] Weekly Update, Release 25.04 Weekly Update, Release 25.04 Apr 10, 2025
@EZoni
Copy link
Member Author

EZoni commented Apr 10, 2025

I tested both the commit before AMReX-Codes/amrex#4357 was merged and the commit where AMReX-Codes/amrex#4357 was merged and I can confirm that the checksums changes come from this PR.

I pushed a commit to reset the checksums. This should be ready for another review once the CI checks have completed.

@EZoni EZoni self-assigned this Apr 10, 2025
@EZoni EZoni merged commit 4a0af0a into BLAST-WarpX:development Apr 10, 2025
37 checks passed
@EZoni EZoni deleted the weekly_update branch April 10, 2025 20:21
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Apr 15, 2025
Weekly update to latest AMReX, pyAMReX, PICSAR:
```
./Tools/Release/updateAMReX.py
./Tools/Release/updatepyAMReX.py
./Tools/Release/updatePICSAR.py
```

New WarpX release 25.04:
```
./Tools/Release/newVersion.sh
```
atmyers pushed a commit to atmyers/WarpX that referenced this pull request Jul 3, 2025
Weekly update to latest AMReX, pyAMReX, PICSAR:
```
./Tools/Release/updateAMReX.py
./Tools/Release/updatepyAMReX.py
./Tools/Release/updatePICSAR.py
```

New WarpX release 25.04:
```
./Tools/Release/newVersion.sh
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: third party Changes in WarpX that reflect a change in a third-party library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants