-
Notifications
You must be signed in to change notification settings - Fork 230
Weekly Update, Release 25.04 #5814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
I suggest that we wait for AMReX-Codes/amrex#4407 to be merged and then rerun the update here to include that bug fix, which is needed in other open PRs, e.g., #5768. |
|
Are you aware of any recent changes in AMReX that could explain the fact that the checksums of the following 3D tests seem to need an update? I am thinking about changes (e.g., bug fixes) since the March release (we skipped a few updates), such as, for example, |
|
Yes the EB change may cause roundoff errors. The other two are not bugs that change the solution. One is like instead of checking n < something, where n is 0, 1, 2, ..., it only checkes n = 0. The other is a harmless bug that could trigger fpe. |
|
Thanks for the update, @WeiqunZhang. The relative errors seem larger than roundoff in some cases. But I guess the magnitude of those may depend on the resolution of the test and other factors as well. I will push a commit to fetch the latest commit before AMReX-Codes/amrex#4357 in order to verify that the checksums changes seen here are indeed due to that bug fix. If that is the case, I will push the back the update and reset the checksums. |
|
With 67c23ab, fetching the latest commit before AMReX-Codes/amrex#4357, all checksums pass: Now testing ab8d4d8, fetching the merge commit of AMReX-Codes/amrex#4357... The checksums changes seem to be caused indeed by AMReX-Codes/amrex#4357. |
|
I tested both the commit before AMReX-Codes/amrex#4357 was merged and the commit where AMReX-Codes/amrex#4357 was merged and I can confirm that the checksums changes come from this PR. I pushed a commit to reset the checksums. This should be ready for another review once the CI checks have completed. |
Weekly update to latest AMReX, pyAMReX, PICSAR: ``` ./Tools/Release/updateAMReX.py ./Tools/Release/updatepyAMReX.py ./Tools/Release/updatePICSAR.py ``` New WarpX release 25.04: ``` ./Tools/Release/newVersion.sh ```
Weekly update to latest AMReX, pyAMReX, PICSAR: ``` ./Tools/Release/updateAMReX.py ./Tools/Release/updatepyAMReX.py ./Tools/Release/updatePICSAR.py ``` New WarpX release 25.04: ``` ./Tools/Release/newVersion.sh ```
Weekly update to latest AMReX, pyAMReX, PICSAR:
New WarpX release 25.04: