-
Notifications
You must be signed in to change notification settings - Fork 230
Remove buggy synchronization at end of steps #5820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
EZoni
merged 18 commits into
BLAST-WarpX:development
from
dpgrote:remove_end_of_step_synchronization
May 7, 2025
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
72bb250
Cleanup
dpgrote 943f8fa
Small fix
dpgrote f1d575b
Additional fix
dpgrote 4fd6da7
Fix in Python interface
dpgrote de793ba
Update broken CI test benchmarks
dpgrote 4f9660e
Merge branch 'development' into remove_end_of_step_synchronization
dpgrote 2d99bde
Merge branch 'development' into remove_end_of_step_synchronization
dpgrote c6678ab
Merge branch 'development' into remove_end_of_step_synchronization
dpgrote 4ce81c4
Set warpx.synchronize_velocity_for_diagnostics=1 to match original be…
dpgrote a3b183e
Update 2D CI benchmarks for Langmuir tests
dpgrote 8be0b48
Update 3d CI benchmarks for Langmuir, electrostatic sphere, and others
dpgrote b79a624
Update RZ CI benchmarks for Langmuir, electrostatic sphere, and space…
dpgrote d798bdd
Snall change in CI check in Examples/Tests/ohm_solver_em_modes/analys…
dpgrote 09f48b3
Update CI test test_3d_electrostatic_sphere_lab_frame
dpgrote 9adf443
Update CI analysis in Examples/Physics_applications/capacitive_discharge
dpgrote 24ca3dd
Merge branch 'development' into remove_end_of_step_synchronization
dpgrote 2c427ef
Update test_3d_effective_potential_electrostatic_picmi.json
dpgrote 7c77652
Add "m_" prefix to is_synchronized
dpgrote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 15 additions & 15 deletions
30
Regression/Checksum/benchmarks_json/test_1d_background_mcc_picmi.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| { | ||
| "lev=0": { | ||
| "rho_electrons": 0.0044328572492614605, | ||
| "rho_he_ions": 0.005198609403474849 | ||
| }, | ||
| "electrons": { | ||
| "particle_momentum_x": 3.5020450942268976e-20, | ||
| "particle_momentum_y": 3.5342700024993965e-20, | ||
| "particle_momentum_z": 1.2596017960675146e-19, | ||
| "particle_position_x": 2139.5967568101983, | ||
| "particle_weight": 14577210937500.002 | ||
| "rho_electrons": 0.004434427147691653, | ||
| "rho_he_ions": 0.005199730582079846 | ||
| }, | ||
| "he_ions": { | ||
| "particle_momentum_x": 2.770046913680294e-19, | ||
| "particle_momentum_y": 2.755651798947783e-19, | ||
| "particle_momentum_z": 3.619494241595636e-19, | ||
| "particle_position_x": 2200.218124999781, | ||
| "particle_weight": 17184714843750.002 | ||
| "particle_momentum_x": 2.770290207735961e-19, | ||
| "particle_momentum_y": 2.756885098058305e-19, | ||
| "particle_momentum_z": 3.586708212111987e-19, | ||
| "particle_position_x": 2200.603966485734, | ||
| "particle_weight": 17188378906250.002 | ||
| }, | ||
| "electrons": { | ||
| "particle_momentum_x": 3.5004216440376824e-20, | ||
| "particle_momentum_y": 3.534005347220309e-20, | ||
| "particle_momentum_z": 1.2485335488279195e-19, | ||
| "particle_position_x": 2140.011854266851, | ||
| "particle_weight": 14581398437500.002 | ||
| } | ||
| } | ||
| } |
36 changes: 18 additions & 18 deletions
36
Regression/Checksum/benchmarks_json/test_1d_dsmc_picmi.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,27 @@ | ||
| { | ||
| "lev=0": { | ||
| "rho_electrons": 0.004437421905874976, | ||
| "rho_he_ions": 0.005201639356131219 | ||
| "rho_electrons": 0.0044359894479080245, | ||
| "rho_he_ions": 0.00519987411353157 | ||
| }, | ||
| "electrons": { | ||
| "particle_momentum_x": 3.522322939921661e-20, | ||
| "particle_momentum_y": 3.5422131770957754e-20, | ||
| "particle_momentum_z": 1.2565723590747718e-19, | ||
| "particle_position_x": 2140.477696059162, | ||
| "particle_weight": 14589250000000.002 | ||
| "particle_momentum_x": 3.5243491288495873e-20, | ||
| "particle_momentum_y": 3.5383746484581363e-20, | ||
| "particle_momentum_z": 1.2458470645227755e-19, | ||
| "particle_position_x": 2140.0087513980293, | ||
| "particle_weight": 14584800781250.002 | ||
| }, | ||
| "he_ions": { | ||
| "particle_momentum_x": 2.769440202095545e-19, | ||
| "particle_momentum_y": 2.7570611462879344e-19, | ||
| "particle_momentum_z": 3.6237149166820755e-19, | ||
| "particle_position_x": 2201.6945467711344, | ||
| "particle_weight": 17194660156250.002 | ||
| "particle_momentum_x": 2.7680739061028134e-19, | ||
| "particle_momentum_y": 2.7567012225748053e-19, | ||
| "particle_momentum_z": 3.589874431755667e-19, | ||
| "particle_position_x": 2200.961686082624, | ||
| "particle_weight": 17188902343750.002 | ||
| }, | ||
| "neutrals": { | ||
| "particle_momentum_x": 1.4066528179969356e-19, | ||
| "particle_momentum_y": 1.4028845765836163e-19, | ||
| "particle_momentum_z": 1.4102130613784624e-19, | ||
| "particle_position_x": 1121.4798733417172, | ||
| "particle_weight": 6.45879999552461e+19 | ||
| "particle_momentum_x": 1.4066528545444887e-19, | ||
| "particle_momentum_y": 1.4028845755701048e-19, | ||
| "particle_momentum_z": 1.4102134299987707e-19, | ||
| "particle_position_x": 1121.4798733430328, | ||
| "particle_weight": 6.458799996100391e+19 | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 9 additions & 9 deletions
18
Regression/Checksum/benchmarks_json/test_1d_laser_acceleration.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 9 additions & 9 deletions
18
Regression/Checksum/benchmarks_json/test_1d_laser_acceleration_picmi.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| { | ||
| "lev=0": { | ||
| "Bx": 178016.8926456872, | ||
| "Bx": 178016.8926454746, | ||
| "By": 0.0, | ||
| "Bz": 0.0, | ||
| "Ex": 0.0, | ||
| "Ey": 40878300517960.234, | ||
| "Ez": 12662514721.141022, | ||
| "Ey": 40878300517911.42, | ||
| "Ez": 12662514721.147837, | ||
| "jx": 0.0, | ||
| "jy": 30370448606626.36, | ||
| "jz": 5611270133558.213, | ||
| "rho": 3098219.079601461 | ||
| "jy": 30370448606611.36, | ||
| "jz": 5611270133568.432, | ||
| "rho": 3098219.079601462 | ||
| }, | ||
| "electrons": { | ||
| "particle_momentum_x": 0.0, | ||
| "particle_momentum_y": 1.2957667586537889e-20, | ||
| "particle_momentum_z": 3.3146691226657727e-21, | ||
| "particle_position_x": 0.022356629283921774, | ||
| "particle_momentum_y": 1.8743344896903162e-20, | ||
| "particle_momentum_z": 3.15210109363816e-21, | ||
| "particle_position_x": 0.0223566292839217, | ||
| "particle_weight": 5.1796875e+18 | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why the error is worse here than before. Note that this has
warpx.synchronize_velocity_for_diagnosticsturned on. With it off, the error is a factor of several worse.