CI: Fix Skipped Required Workflows (again) #5907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
commented
Jun 17, 2025
EZoni
commented
Jun 17, 2025
Comment on lines
-8
to
-9
| schedule: | ||
| - cron: "27 3 * * 0" |
Member
Author
There was a problem hiding this comment.
Removed cron schedule for CodeQL workflows (on Sundays at 3:27 AM...?).
EZoni
force-pushed
the
ci_docs_skip_checks_amrex_take2
branch
from
5d8923f to
a6a94e4
Compare
Member
Author
|
The latest bug fix seems to have worked, if you look at the CI output for 705fd1a. I will push one more commit to resolve the point
mentioned in the PR description (this new commit will trigger CI, as expected), and then I think we could merge and test right away in #5883 (which is a docs-only PR), after rebasing that PR on |
EZoni
commented
Jun 18, 2025
EZoni
changed the title
ax3l
approved these changes
Jun 20, 2025
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Jul 3, 2025
Follow up on BLAST-WarpX#5889 and fix the issue that appeared in BLAST-WarpX#5883, related to the fact that we add the `clang-tidy` checks automatically from a matrix, rather than manually as separate jobs in the workflow file. Note that I had managed to fix a similar issue in the alternative in-house implementation I had proposed in BLAST-WarpX#5469. To-do: - [x] Fix main issue by applying the `if` condition at the `step` level (rather than the `job` level) - [x] Remove `cron` schedule for CodeQL workflows (on Sundays at 3:27 AM...?) - [x] Revert change in .github/workflows/check_changes.yml (implemented only to test the PR) Future PRs: - Skip also CodeQL workflows (C++ and Python files analysis) - not working yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #5889 and fix the issue that appeared in #5883, related to the fact that we add the
clang-tidychecks automatically from a matrix, rather than manually as separate jobs in the workflow file.Note that I had managed to fix a similar issue in the alternative in-house implementation I had proposed in #5469.
To-do:
ifcondition at thesteplevel (rather than thejoblevel)cronschedule for CodeQL workflows (on Sundays at 3:27 AM...?)Future PRs: