-
Notifications
You must be signed in to change notification settings - Fork 230
Energy-preserving explicit PIC-MCC algorithm: electromagnetic #6275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Basically the goal here will be to have the analysis of the test |
|
Discussed with @oshapoval offline:
|
|
I start requesting your review in case you have comments on the early draft. I don't think it's working correctly yet. |
Source/Evolve/WarpXEvolve.cpp
Outdated
| // communicate particle data | ||
| mypc->Redistribute(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better performance, reproduce the logic in HandleParticlesAtBoundaries to ensure only local communication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be a follow-up optimization PR, since I think it'd require some refactoring of the code in HandleParticlesAtBoundaries. We should reference the first comment of this thread into a new issue to track this when the PR is merged.
74c907f to
d16803f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
8f543ed to
a08f073
Compare
a08f073 to
277fee4
Compare
Overview
Follow up on #5955 and implement the electromagnetic part of the energy-preserving PIC-MCC algorithm described in (Vay, Jean-Luc, et al. "Energy-preserving coupling of explicit particle-in-cell with Monte Carlo collisions." Physical Review E 111.2 (2025): 025306) (i.e., explicit PIC coupled with Monte Carlo collisions).
Notes
To do
communicate=1toAddRealComp.