Checkpoint/Plotfile: Robust Bounds Calc #6394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of the bounds in plotfiles (incl. checkpoints) appears fishy. It relies on the order of the boxes in the box array, which is not always pointing to a box on the lower/upper bound of the simulation when load balancing is used. This can corrupt checkpoints (plotfiles) when writing, by a) filtering out valid particles & fields and b) remembering the wrong simulation meta-data for the simulation geometry of fields/particles. Co-authored-by: Andrew Myers <[email protected]> Co-authored-by: Remi Lehe <[email protected]> Co-authored-by: Davide Terzani <[email protected]>
ax3l
added
bug
Member
|
Is this ready to be tested at full scale or do you need to make some more changes? |
Member
Author
|
I tested it on my minimal reproducer and it does not fix the issue we observe. Nonetheless, I would change the logic here because it does not look safe under load balancing. |
WeiqunZhang
reviewed
Nov 15, 2025
Member
|
I agree with the change. Although the existing code does not produce incorrect results, it should be avoided. It has nothing to do with load balancing. But it depends on how amrex does |
Co-authored-by: Weiqun Zhang <[email protected]>
ax3l
added
cleaning
atmyers
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of the bounds in plotfiles (incl. checkpoints) appears fishy. It relies on the order of the boxes in the box array, which is not always pointing to a box on the lower/upper bound of the simulation when load balancing is used.
This can corrupt checkpoints (plotfiles) when writing, by a) filtering out valid particles & fields and b) remembering the wrong simulation meta-data for the simulation geometry of fields/particles.
Related to #6392
Co-authored-by: @atmyers
Co-authored-by: @RemiLehe
Co-authored-by: @titoiride
Introduced in #1085 (refined in #1241)
Follow-up
BTDiagnostics.cppcontains similar assumptions/logic it seems and needs a similar fix.