Skip to content

Forward SoA Names to Temporary Tiles #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

Forward SoA Names to Temporary Tiles #6413

merged 1 commit into from
Nov 24, 2025

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Nov 21, 2025 •
edited
Loading

Ensure temporary particle tiles have access to SoA names, by passing in the names from their referenced PC.

Related to #6409

@ax3l
Forward SoA Names to Temporary Tiles
181d400 
Ensure temporary particle tiles have access to SoA names,
by passing in the names from their referenced PC.
@ax3l ax3l requested review from EZoni and atmyers November 21, 2025 18:39
@ax3l ax3l added cleaning Clean code, improve readability component: core Core WarpX functionality labels Nov 21, 2025
@ax3l
Copy link
Member Author

ax3l commented Nov 21, 2025

@EZoni can you rebase #6275 against this and see if it fixes your issues?

If not, let us print the number of runtime real components in the photon species before your crash and the vector of real names again.

@EZoni
Copy link
Member

EZoni commented Nov 21, 2025

@EZoni can you rebase #6275 against this and see if it fixes your issues? If not, let us print the number of runtime real components in the photon species before your crash and the vector of real names again.

It doesn't seem to fix the issue with the test test_1d_photoneutralization_dsmc in #6275, but we should probably merge this PR anyways if it makes things more robust. I will report more debugging info on the test directly in #6275.

@EZoni EZoni mentioned this pull request Nov 21, 2025
Open
6 tasks
@ax3l
Copy link
Member Author

ax3l commented Nov 24, 2025

Agreed. Feel free to merge.

@EZoni EZoni merged commit d158107 into BLAST-WarpX:development Nov 24, 2025
50 checks passed
@ax3l ax3l deleted the fix-temp-tiles-names branch December 1, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atmyers atmyers atmyers approved these changes

@EZoni EZoni Awaiting requested review from EZoni

Assignees

@EZoni EZoni

Labels

cleaning Clean code, improve readability component: core Core WarpX functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ax3l @EZoni @atmyers