Skip to content

Conversation

@WeiqunZhang
Copy link
Member

This appears necessary for PETSc to work.

This appears necessary for PETSc to work.
@JustinRayAngus JustinRayAngus added the component: implicit solvers Anything related to implicit solvers label Nov 22, 2025
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JustinRayAngus
Copy link
Contributor

JustinRayAngus commented Nov 24, 2025

Below is a comparison of the running-average numbers of GMRES iterations/Newton iteration from a 2D planar pinch problem with the duplicates (left) and without the duplicates (right). The number of GMRES iterations is significantly improved with the duplicates removed, permitting a practical value for the additive Schwarz method (asm) overlap value.

image image

The setup for this test is a 224x16 grid with 100 ppc for each species at t = 0. The initial time step is such that wpe0*dt = 36 with wpe0 the plasma frequency measure with the initial density (ne = ni = 1e17/cm^3). These simulations were performed using 56 Dane cores (8x8 boxes). The figure on the left (with duplicates) is obtained using PR #6396 with a mass matrix pc width = 1. The figure on the right (without duplicates) is obtained with a branch where PR #6396 is merged with this PR.

Copy link
Contributor

@JustinRayAngus JustinRayAngus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JustinRayAngus JustinRayAngus merged commit ddf9342 into BLAST-WarpX:development Nov 24, 2025
50 checks passed
@WeiqunZhang WeiqunZhang deleted the rm_dup branch November 24, 2025 18:49
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: implicit solvers Anything related to implicit solvers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants