Fix PEC_insulators #6424
Merged
Fix PEC_insulators #6424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
bug
JustinRayAngus
approved these changes
Nov 26, 2025
Contributor
JustinRayAngus
left a comment
JustinRayAngus
left a comment
There was a problem hiding this comment.
Looks good. Thanks Dave.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vectors holding the parsers were not being setup correctly, leading to out of bounds access. The fix is to add empty parsers for the fields that are normal to the boundaries so that the vectors have the correct length (the number of dimensions).
Also, comments were cleaned up for clarity.