PEC_Insulator cleanup

[dpgrote]

This cleans up the variable names used in the PEC_Insulator class to increase clarity and readability. It also adds accessors allowing checks of whether there are E or B fields being set by the boundary condition.

[JustinRayAngus]

Maybe make the description consistent with changes from your previous PR?

e.g., the flags for the x-field at the lower boundaries

[dpgrote]

This is fixed with a merge of development

[JustinRayAngus]

Is it? Looks like it is still the old way.

[JustinRayAngus]

Hi Dave,

Do think that you could use this new functionality in the ImplicitSolver::convertFieldBCToLinOpBC() routine in /FieldSolver/ImplicitSolvers/ImplicitSolver.cpp ?

The idea is to modify the below lines to use LinOpBCType::Dirichlet when setE is true for FieldBoundaryType::PECInsulator

else if (a_fbc[i] == FieldBoundaryType::PECInsulator) {
            ablastr::warn_manager::WMRecordWarning("Implicit solver",
                "With PECInsulator, in the Curl-Curl preconditioner Neumann boundary will be used since the full boundary is not yet implemented.",
                ablastr::warn_manager::WarnPriority::medium);
            lbc[i] = LinOpBCType::symmetry;
        }

[JustinRayAngus]

Hi Dave,

Do think that you could use this new functionality in the ImplicitSolver::convertFieldBCToLinOpBC() routine in /FieldSolver/ImplicitSolvers/ImplicitSolver.cpp ?

The idea is to modify the below lines to use LinOpBCType::Dirichlet when setE is true for FieldBoundaryType::PECInsulator

else if (a_fbc[i] == FieldBoundaryType::PECInsulator) {
            ablastr::warn_manager::WMRecordWarning("Implicit solver",
                "With PECInsulator, in the Curl-Curl preconditioner Neumann boundary will be used since the full boundary is not yet implemented.",
                ablastr::warn_manager::WarnPriority::medium);
            lbc[i] = LinOpBCType::symmetry;
        }

On second thought, this can be implemented in a future PR.

[JustinRayAngus]

Thanks Dave!

Only one minor thing left. I think the comments in header file still need to be adjusted to match those in the cpp file.