collisions should be after call to HandleParticlesAtBoundaries() #6458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinRayAngus
added
bug
RemiLehe
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the collisions for the implicit solver to the proper place in the Evolve loop. This fixes a bug introduced in PR #6428, where the collisions are moved from just before to just after the PIC advance. (See #6449). However, with this change I noticed odd behavior in simulation outputs at processor boundaries late in time for highly collisional simulations. The fix is that the collisions should be placed after the particle communication and boundary handling is performed, which occurs later in the Evolve loop.