feat: parameterize nginx cache and fix missing image variables#32
Open
hafsaimranattaria71125 wants to merge 1 commit into
Open
feat: parameterize nginx cache and fix missing image variables#32hafsaimranattaria71125 wants to merge 1 commit into
hafsaimranattaria71125 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-NGINX Cache: Parameterized cache durations in values.yaml.template for sPHENIX and Belle2_Java to allow flexible configuration.
-Template Fix: Resolved rendering errors by adding the missing nginx_docker_image variable to the templates and values files.
Scope: Changes applied to npdbchart_sphenix and npdbchart_belle2_java.
Verification: Confirmed successful YAML generation via helm template for both modified charts.