build(docker): remove OptiX_INSTALL_DIR and simplify CMake config#169
Merged
Conversation
plexoos
force-pushed
the
update-dockerfile
branch
from
760a058 to
3476622
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CMake configuration in Docker builds by removing the explicit -DOptiX_INSTALL_DIR=/opt/optix argument from both the release and debug build stages. The FindOptiX.cmake module already includes /opt/optix in its default search paths, making this explicit specification unnecessary.
Note: The PR title mentions "remove OPTICKS_PREFIX" but this is inaccurate—OPTICKS_PREFIX is retained and still used throughout the Docker configuration. Only OptiX_INSTALL_DIR was removed.
Key Changes
- Removed
-DOptiX_INSTALL_DIR=/opt/optixfrom the release stage CMake configuration - Removed
-DOptiX_INSTALL_DIR=/opt/optixfrom the debug/develop stage CMake configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plexoos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.