Skip to content

chore(examples): add simple example demonstrating how to build against eic-opticks#172

Merged
plexoos merged 1 commit into
mainfrom
add-example
Nov 25, 2025
Merged

chore(examples): add simple example demonstrating how to build against eic-opticks#172
plexoos merged 1 commit into
mainfrom
add-example

Conversation

@plexoos

@plexoos plexoos commented Nov 24, 2025

Copy link
Copy Markdown
Member

No description provided.

github-actions[bot]

This comment was marked as resolved.

@github-actions github-actions Bot dismissed their stale review November 24, 2025 18:33

outdated suggestion

github-actions[bot]

This comment was marked as resolved.

@github-actions github-actions Bot dismissed their stale review November 24, 2025 18:35

outdated suggestion

@plexoos plexoos force-pushed the add-example branch 2 times, most recently from eaf82f4 to 182f59b Compare November 25, 2025 00:10

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v18.1.3

Click here for the full clang-format patch
diff --git a/examples/simphox.cpp b/examples/simphox.cpp
index 72653a1..59bacaf 100644
--- a/examples/simphox.cpp
+++ b/examples/simphox.cpp
@@ -12 +11,0 @@
-
@@ -23,3 +22,3 @@ int main(int argc, char **argv)
-    size_t num_floats = phs.size()*4*4;
-    float* data = reinterpret_cast<float*>(phs.data());
-    NP* photons = NP::MakeFromValues<float>(data, num_floats);
+    size_t num_floats = phs.size() * 4 * 4;
+    float *data = reinterpret_cast<float *>(phs.data());
+    NP *photons = NP::MakeFromValues<float>(data, num_floats);
@@ -27 +26 @@ int main(int argc, char **argv)
-    photons->reshape({ static_cast<int64_t>(phs.size()), 4, 4});
+    photons->reshape({static_cast<int64_t>(phs.size()), 4, 4});

Have any feedback or feature suggestions? Share it here.

Comment thread examples/simphox.cpp Outdated
Comment thread examples/simphox.cpp Outdated
Comment thread examples/simphox.cpp Outdated
@github-actions github-actions Bot dismissed their stale review November 25, 2025 00:18

outdated suggestion

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v18.1.3

Click here for the full clang-format patch
diff --git a/examples/simphox.cpp b/examples/simphox.cpp
index 3d6c4ff..59bacaf 100644
--- a/examples/simphox.cpp
+++ b/examples/simphox.cpp
@@ -12 +11,0 @@
-

Have any feedback or feature suggestions? Share it here.

Comment thread examples/simphox.cpp Outdated
@github-actions github-actions Bot dismissed their stale review November 25, 2025 00:19

outdated suggestion

@plexoos plexoos merged commit a3047f3 into main Nov 25, 2025
3 checks passed
@plexoos plexoos deleted the add-example branch November 25, 2025 18:33
@plexoos plexoos added this to simphony Mar 13, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in simphony Mar 13, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in simphony Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant