Restore original field order in sevent struct for binary compatibility#194
Closed
Copilot wants to merge 6 commits into
Closed
Restore original field order in sevent struct for binary compatibility#194Copilot wants to merge 6 commits into
Copilot wants to merge 6 commits into
Conversation
…using Geant4 with Qt viz driver that Nicola reports caused some vtable related crash
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
Co-authored-by: plexoos <5005079+plexoos@users.noreply.github.com>
Co-authored-by: plexoos <5005079+plexoos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update QEvent.hh to QEvt.hh for compatibility issues
Restore original field order in sevent struct for binary compatibility
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #193 where the
hitandphotonfield order in theseventstruct was inadvertently swapped during the QEvent→QEvt rename.Changes
sysrap/sevent.h:hitbeforephotonRationale
The
seventstruct is uploaded to device memory viaQU::UploadArray. Field ordering affects:Original (main branch):
After 6439904 (incorrect):
Restored:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.