build(devcontainer): pin LLVM tooling to version 23#324
Open
plexoos wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the devcontainer’s LLVM tooling to a specific major version to prevent silent toolchain changes across rebuilds, and improves the LLVM APT repo selection logic in the feature installer.
Changes:
- Pin the LLVM devcontainer feature to version
23in.devcontainer/devcontainer.json. - Update the LLVM feature installer to prefer a per-version apt.llvm.org suite when it exists (with fallback to the generic suite).
- Add an early failure check when requested LLVM packages are not found in the APT cache.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .devcontainer/features/llvm/install.sh | Adds versioned-suite selection and early package-availability checks for LLVM tooling installs. |
| .devcontainer/devcontainer.json | Pins the LLVM feature option version to 23 to avoid toolchain drift. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@ggalgoczi any comments? |
Pin the local LLVM devcontainer Feature to version 23 to avoid silent toolchain drift across rebuilds. Update the installer to prefer a versioned apt.llvm.org suite when it exists, while falling back to the generic suite for current tip versions that do not yet have a dedicated per-version suite. Fail early when the requested clang-format, clangd, or clang-tidy packages are not available from the selected repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the local LLVM devcontainer Feature to version 23 to avoid silent toolchain drift across rebuilds.
Update the installer to prefer a versioned apt.llvm.org suite when it exists, while falling back to the generic suite for current tip versions that do not yet have a dedicated per-version suite.
Fail early when the requested clang-format, clangd, or clang-tidy packages are not available from the selected repository.