Skip to content

build(devcontainer): pin LLVM tooling to version 23#324

Open
plexoos wants to merge 1 commit into
mainfrom
dev-clang-format
Open

build(devcontainer): pin LLVM tooling to version 23#324
plexoos wants to merge 1 commit into
mainfrom
dev-clang-format

Conversation

@plexoos
Copy link
Copy Markdown
Member

@plexoos plexoos commented May 8, 2026

Pin the local LLVM devcontainer Feature to version 23 to avoid silent toolchain drift across rebuilds.

Update the installer to prefer a versioned apt.llvm.org suite when it exists, while falling back to the generic suite for current tip versions that do not yet have a dedicated per-version suite.

Fail early when the requested clang-format, clangd, or clang-tidy packages are not available from the selected repository.

Copilot AI review requested due to automatic review settings May 8, 2026 14:14
@plexoos plexoos requested a review from ggalgoczi May 8, 2026 14:15
@plexoos plexoos self-assigned this May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the devcontainer’s LLVM tooling to a specific major version to prevent silent toolchain changes across rebuilds, and improves the LLVM APT repo selection logic in the feature installer.

Changes:

  • Pin the LLVM devcontainer feature to version 23 in .devcontainer/devcontainer.json.
  • Update the LLVM feature installer to prefer a per-version apt.llvm.org suite when it exists (with fallback to the generic suite).
  • Add an early failure check when requested LLVM packages are not found in the APT cache.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.devcontainer/features/llvm/install.sh Adds versioned-suite selection and early package-availability checks for LLVM tooling installs.
.devcontainer/devcontainer.json Pins the LLVM feature option version to 23 to avoid toolchain drift.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .devcontainer/features/llvm/install.sh
@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented May 13, 2026

@ggalgoczi any comments?

Pin the local LLVM devcontainer Feature to version 23 to avoid silent toolchain drift across
rebuilds.

Update the installer to prefer a versioned apt.llvm.org suite when it exists, while falling back to
the generic suite for current tip versions that do not yet have a dedicated per-version suite.

Fail early when the requested clang-format, clangd, or clang-tidy packages are not available from
the selected repository.
@plexoos plexoos force-pushed the dev-clang-format branch from 66469bc to 2d0543d Compare May 13, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants