chore: rename project for devcontainer#326
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3adf6689f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| endif() | ||
|
|
||
| project(eic-opticks VERSION 0.5.0 LANGUAGES CXX CUDA) | ||
| project(simphony VERSION 0.5.0 LANGUAGES CXX CUDA) |
There was a problem hiding this comment.
Renaming the top-level project to simphony changes all exported package artifacts (${PROJECT_NAME}Config.cmake, ${PROJECT_NAME}:: namespace, and install include roots) because the install/export logic is parameterized by PROJECT_NAME in this same file. Existing consumers in this repo still depend on find_package(eic-opticks) and eic-opticks::... targets (for example examples/*/CMakeLists.txt and dd4hepplugins/CMakeLists.txt standalone mode), so those builds will fail to configure against a newly installed package from this commit.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@ggalgoczi will take care of this later. The repository/package rename is meant to carry through to the installed CMake package as well, so I do want the exported artifacts to move from eic-opticks to simphony (simphonyConfig.cmake, simphony::..., and the install include root).
| ENV OPTICKS_HOME=/workspaces/eic-opticks | ||
| ENV OPTICKS_BUILD=/opt/eic-opticks/build | ||
| ENV OPTICKS_PREFIX=/opt/simphony | ||
| ENV OPTICKS_HOME=/workspaces/simphony |
There was a problem hiding this comment.
Changing OPTICKS_HOME to /workspaces/simphony breaks scripts that still default to the old repo path, so commands that rely on defaults now resolve missing files in the dev container. For example, examples/MC_Truth/run.sh defaults REPO=/workspaces/eic-opticks and derives GDML/macro paths from it, which no longer matches this image’s workspace root after this change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Updates devcontainer-related naming and default install/workspace paths to align with the repository name “simphony”, including updating the CMake project name.
Changes:
- Renamed the CMake project from
eic-optickstosimphony. - Updated Docker image environment defaults (
OPTICKS_PREFIX,OPTICKS_HOME,OPTICKS_BUILD) to/opt/simphonyand/workspaces/simphony. - Renamed devcontainer metadata and updated GHCR base image references from
eic-optickstosimphony.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile | Updates default OPTICKS paths to simphony locations for devcontainer builds. |
| CMakeLists.txt | Renames the CMake project to simphony (affects exported package/namespace and install layout). |
| .devcontainer/devcontainer.json | Renames devcontainer and updates cacheFrom image reference. |
| .devcontainer/codespace/devcontainer.json | Renames Codespace devcontainer and updates base image reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| endif() | ||
|
|
||
| project(eic-opticks VERSION 0.5.0 LANGUAGES CXX CUDA) | ||
| project(simphony VERSION 0.5.0 LANGUAGES CXX CUDA) |
| ENV OPTICKS_PREFIX=/opt/simphony | ||
| ENV OPTICKS_HOME=/workspaces/simphony | ||
| ENV OPTICKS_BUILD=/opt/simphony/build |
plexoos
force-pushed
the
rename-proj-devcontainer
branch
from
3adf668 to
81970d5
Compare
|
The updated devcontainer is needed to unblock development during the rename transition before we cut a tag. The noted issues are valid, and will be addressed in follow-up PRs. |
No description provided.